Skip to content

remove the default replicas from validation #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Madhu-1 wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −48
Open

remove the default replicas from validation #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/v1/driver_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,12 @@ type ControllerPluginSpec struct {
//+kubebuilder:validation:Optional
DeploymentStrategy *appsv1.DeploymentStrategy `json:"deploymentStrategy,omitempty"`

// Set replicas for controller plugin's deployment. Defaults to 2.
// On single-node clusters, the operator automatically caps the replica
// count to the number of available nodes when this field is not set.
// Set replicas for controller plugin's deployment.
// If not set, defaults to 2 or to the number of available nodes
// on single-node clusters. When OperatorConfig specifies a replica
// count, it is used as the default for all drivers.
//+kubebuilder:validation:Optional
//+kubebuilder:validation:Minimum:=1
//+kubebuilder:default:=2
Replicas *int32 `json:"replicas,omitempty"`

// Resource requirements for controller plugin's containers
Expand Down
8 changes: 4 additions & 4 deletions config/crd/bases/csi.ceph.io_drivers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,11 +1076,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
8 changes: 4 additions & 4 deletions config/crd/bases/csi.ceph.io_operatorconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,11 +1085,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
16 changes: 8 additions & 8 deletions deploy/all-in-one/install-openshift.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,11 +1459,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down Expand Up @@ -8672,11 +8672,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
16 changes: 8 additions & 8 deletions deploy/all-in-one/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,11 +1459,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down Expand Up @@ -8672,11 +8672,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
8 changes: 4 additions & 4 deletions deploy/charts/ceph-csi-operator/templates/driver-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,11 +1076,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
8 changes: 4 additions & 4 deletions deploy/charts/ceph-csi-operator/templates/operatorconfig-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,11 +1082,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
16 changes: 8 additions & 8 deletions deploy/multifile/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,11 +1450,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down Expand Up @@ -8663,11 +8663,11 @@ spec:
For example, OpenShift with SELinux restrictions requires the pod to be privileged to write to hostPath.
type: boolean
replicas:
default: 2
description: |-
Set replicas for controller plugin's deployment. Defaults to 2.
On single-node clusters, the operator automatically caps the replica
count to the number of available nodes when this field is not set.
Set replicas for controller plugin's deployment.
If not set, defaults to 2 or to the number of available nodes
on single-node clusters. When OperatorConfig specifies a replica
count, it is used as the default for all drivers.
format: int32
minimum: 1
type: integer
Expand Down
8 changes: 4 additions & 4 deletions vendor/github.com/ceph/ceph-csi-operator/api/v1/driver_types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading