Open
Conversation
* EEmulticlass_tinymodel
* Restructure model configuration and handling
…ID evaluation * Remove redundant conifer header
…s introducing custom packing/unpacking for barrel/endcap
…ng and unpacking * Restructure PFCluster object to store the decoded calorimeter info across the whole detector plus some other fixes. * Specialize TkObj packing for barrel and endcap
Overload most used patterns
Initial implementation of emulation of pt corrections for HGC clusters can now emulate both corrections or corrected pt Update HGC model and add softmax
code format Fix TkEm WP and GCT energy
…in the review (cms-sw#24) Address review comments + fixes for TDR regionizer (not used in default CMSSW configuration)
cerminar
force-pushed
the
151X_calodev_v2
branch
from
046c793 to
65e769f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes try to address the review comments in cms-sw#48002 . For hoe I completely removed it, since it will go away, but I see you fixed it by getting the bit counts correct. I think either solution is fine.
I also did the
= defaultchange for the destructors in the converters, assuming I understood the right way to do it. It compiles fine. For the muon converter, it seems like I inadvertently made a whitespace change when saving things. I think the file was in DOS format (with CR LF) while I wound up saving it in unix format.Anyway, those changes are in one of the two commits. Feel free to cherry pick or do you own edits.
The other commit is just adding comments to the initial clocks to estimate the timing for the TDR regionzer. Getting the relative timing between inputs coming on different fibers is quite difficult. (The TDR emulator has always ignored the order of objects when deciding if an event matched, and this was my attempt to make the order match, though it may still need tuning.)