Centralize all key fetching logic#2015
Open
inteon wants to merge 1 commit intochainguard-dev:mainfrom
Open
Conversation
inteon
force-pushed
the
keyring_package
branch
3 times, most recently
from
adb3c10 to
193a8af
Compare
Author
|
@markusthoemmes could you make CI run on this PR? What do you think about the general direction of this PR? |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces new
chainguard.dev/apko/pkg/apk/apk/keyringpackage, centralizing all key fetching logic.NOTE: when producing the lock file, we now also download all keys; this allows us to deduplicate these keys, we might want to include key hashes in the lock files in the future