Skip to content

Quick update on JavaScript build config#3066

Open
s-stumbo wants to merge 1 commit intomainfrom
js-url
Open

Quick update on JavaScript build config#3066
s-stumbo wants to merge 1 commit intomainfrom
js-url

Conversation

@s-stumbo
Copy link
Contributor

[X] Check if this is a typo or other quick fix and ignore the rest :)

Type of change

What should this PR do?

Under JavaScript Build Configuration > npm > Minimal example project,
changed this

For testing purposes, you can use direct access and environment variables as detailed in the access documentation. Once the environment variables are set, the following steps configure registry access with authentication in the .npmrc file in the current project directory:

to this

For testing purposes, you can use direct access and environment variables as
detailed in the access documentation. For
production use, set the config URL to either your organization's artifact
manager alreaady in use, or directly to libraries.cgr.dev/javascript. Once the
URL and environment variables are set, the following steps configure registry
access with authentication in the .npmrc file in the current project
directory:

Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
@s-stumbo s-stumbo requested a review from a team as a code owner March 12, 2026 12:58
@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 2fd1474
🔍 Latest deploy log https://app.netlify.com/projects/ornate-narwhal-088216/deploys/69b2b865499b8200084995db
😎 Deploy Preview https://deploy-preview-3066--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@matthewhelmke matthewhelmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should do this change at all.

the environment variables are set, the following steps configure registry
detailed in the [access documentation](/chainguard/libraries/access/#env). For
production use, set the config URL to either your organization's artifact
manager alreaady in use, or directly to `libraries.cgr.dev/javascript`. Once the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tis is wrong .. the correct URL requires a / at the end and its actually documented right below. And we should not suggest direct access for production use inconsistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants