Conversation
pannepu
requested review from
aggarwalvinay,
ansonipaypal,
jagadeeshdeepak-pp and
yusharma-pp
|
@pannepu can you document this and attach it to the setup page here? |
| if (this._chargehound.options.protocol === 'https://') { | ||
| req = https.request(reqOpts).setTimeout(this.getTimeout()) | ||
| connectEv = 'secureConnect' | ||
| } else { |
There was a problem hiding this comment.
can we not see if the env is local or not and then use the protocol based on that?
Done. |
lib/api-requestor.js
Outdated
| req = https.request(reqOpts).setTimeout(this.getTimeout()) | ||
| connectEv = 'secureConnect' | ||
| } else { | ||
| } else if ((this._chargehound.options.protocol === 'http://') && (this._chargehound.options.host === 'localhost')) { |
There was a problem hiding this comment.
python dont have else if. please change it to elif
There was a problem hiding this comment.
I agree with deepak, can we check current values of protocol for all environment (local, stage, prod) and use it accordingly here instead of relying on protocol value
There was a problem hiding this comment.
python dont have else if. please change it to elif
These changes are done in javascript file.
lib/index.js
Outdated
| const CHARGEHOUND_HOST = 'api.chargehound.com' | ||
| const CHARGEHOUND_BASE_PATH = '/v1/' | ||
| const CHARGEHOUND_TIMEOUT = 60 * 1000 | ||
| const CHARGEHOUND_ENV = 'prod' |
There was a problem hiding this comment.
| const CHARGEHOUND_ENV = 'prod' | |
| const CHARGEHOUND_DEFAULT_ENV = 'prod' |
Fixing snyk issue
3 participants
Fixing snyk issue
JIRA ID | Git Issue
DTFPCHG-178
Change Type
Change Impact
Summary
Demo
Notes
Testing Instructions