gemspec: require Ruby 2.7+ and Rails 7+ related gems#99
Open
alagos wants to merge 2 commits intocharkost:mainfrom
Open
gemspec: require Ruby 2.7+ and Rails 7+ related gems#99alagos wants to merge 2 commits intocharkost:mainfrom
alagos wants to merge 2 commits intocharkost:mainfrom
Conversation
- Prosopite uses `connection_db_config`, which is not available on older Active Record versions. - Align runtime constraints with actual compatibility to avoid install-time/runtime mismatches (see charkost#98).
There was a problem hiding this comment.
Pull request overview
Updates Prosopite’s gemspec constraints to match the runtime APIs it uses (notably ActiveRecord::Base.connection_db_config), preventing install-time success followed by runtime failures on older stacks.
Changes:
- Bump required Ruby version to
>= 2.7.0. - Add a runtime dependency on
activerecord >= 7.0and removeactiverecordfrom development dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Prosopite references `Rails` at runtime (`Rails.logger`, `Rails.root`, `Rails.backtrace_cleaner`) - Prevent install/runtime mismatch when only `activerecord` is present - Move `railties` out of development dependencies into runtime dependencies
alagos
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connection_db_config, which is not available on older Active Record versions.