fix: parseOsc correctly reports ClipboardEvent selection on base64 failure#116
Open
masterkeysrd wants to merge 1 commit into
Open
fix: parseOsc correctly reports ClipboardEvent selection on base64 failure#116masterkeysrd wants to merge 1 commit into
masterkeysrd wants to merge 1 commit into
Conversation
…ilure Previously, the OSC 52 parser used strings.Split which could corrupt the payload if the base64 content contained semicolons. It also required a non-empty selection code, so empty selections silently dropped the event, and on invalid base64 it returned the raw un-decoded string as the content instead of an empty string — causing the wrong selection and content to be reported in ClipboardEvent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the OSC 52 parser used
strings.Split, which could corrupt the payload if the base64 content contained semicolons. It also required a non-empty selection code, so empty selections silently dropped the event, and on invalidbase64it returned the raw, un-decoded string as the content instead of an empty string — causing the wrong selection and content to be reported in ClipboardEvent.Before passing an empty clipboard event
After my changes, now the base64 is correctly populated in the Clipboard Event
CONTRIBUTING.md.