Skip to content

Issue #13491: Simplify setterHaveSinceTag#18989

Open
DakshRJain737 wants to merge 1 commit intocheckstyle:masterfrom
DakshRJain737:simplify-settersHaveSinceTag
Open

Issue #13491: Simplify setterHaveSinceTag#18989
DakshRJain737 wants to merge 1 commit intocheckstyle:masterfrom
DakshRJain737:simplify-settersHaveSinceTag

Conversation

@DakshRJain737
Copy link
Copy Markdown
Contributor

@DakshRJain737 DakshRJain737 commented Feb 22, 2026 •
edited
Loading

Issue: #13491

Simplified setterHaveSinceTag by seperating the method check and class check.

Added new internal check SetterSinceTagCheck.
contribution: checkstyle/contribution#1036

@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Feb 22, 2026

@romani Is a custom check necessary for this according to you?

romani
romani requested changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Comment thread config/suppressions-xpath.xml Outdated
@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from 0d9cc49 to e1c8b1e Compare February 28, 2026 15:41
@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Feb 28, 2026

@romani Done, Added a new internal check that removes the need for setterHaveSinceTag Xpath quere.
Please review it.

@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Feb 28, 2026

Working on CI.

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from e1c8b1e to ca23358 Compare February 28, 2026 17:57
romani
romani requested changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot expose this Check to public, it does not make any sense out of Checkstyle code base.

Comment thread config/checkstyle-checks.xml Outdated
@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch 2 times, most recently from cd003a3 to ff08b6e Compare March 1, 2026 09:44
@romani
Copy link
Copy Markdown
Member

romani commented Mar 9, 2026

until CI is green , humas do no review

@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Mar 9, 2026

until CI is green , humas do no review

I was trying to figure out how internal checks are written.
I couldn't understand the way they are present. I was trying to figure that out.

@romani
Copy link
Copy Markdown
Member

romani commented Mar 9, 2026

Please read and watch videos at Starting_Development.
few last videos focusng on how to read CIs

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch 3 times, most recently from eb89317 to 574be46 Compare March 10, 2026 13:02
@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Mar 10, 2026

done

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from 574be46 to b4f1ef1 Compare March 12, 2026 11:19
@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Mar 12, 2026

Any changes??

@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Apr 18, 2026

@romani Please review

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from b4f1ef1 to b2b72f7 Compare April 18, 2026 13:28
@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Apr 19, 2026

@romani CI Failures seem to fail because of other reasons.

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from b2b72f7 to e0ced99 Compare April 19, 2026 15:08
@romani
Copy link
Copy Markdown
Member

romani commented Apr 19, 2026

please make extra commit with mistake in code to show that it actually violates code if someone forget to do this.

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from e0ced99 to 135f368 Compare April 20, 2026 10:43
@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Apr 20, 2026

please make extra commit with mistake in code to show that it actually violates code if someone forget to do this.

Yes the test is working fine and clearly able to find the violation


image

@DakshRJain737
Copy link
Copy Markdown
Contributor Author

DakshRJain737 commented Apr 21, 2026

@romani Should i revert back the change if the results are satisfactory?

@DakshRJain737 DakshRJain737 force-pushed the simplify-settersHaveSinceTag branch from 135f368 to 82bb60c Compare April 21, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DakshRJain737 @romani