Skip to content

[EnvironmentCookbookVersionsEndpoint#sort_versions] Change .reverse to .reverse!#362

Merged
tpowell-progress merged 1 commit intochef:mainfrom
dafyddcrosby:sort_versions_reverse
Feb 10, 2026
Merged

[EnvironmentCookbookVersionsEndpoint#sort_versions] Change .reverse to .reverse!#362
tpowell-progress merged 1 commit intochef:mainfrom
dafyddcrosby:sort_versions_reverse

Conversation

@dafyddcrosby
Copy link
Contributor

Squeeze out a teensy amount of perf doing in-place reversal

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: David Crosby <dcrosby@fb.com>
@sonarqubecloud
Copy link

@dafyddcrosby dafyddcrosby marked this pull request as ready for review February 10, 2026 21:57
@dafyddcrosby dafyddcrosby requested review from a team and jaymzh as code owners February 10, 2026 21:57
@tpowell-progress tpowell-progress merged commit af9fbd6 into chef:main Feb 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants