Conversation
Introduce a context-aware refactor of common Helm templates to support chartNameOverride and use a passed-in root context for lookups. Move DB initialization manifests into gearbox-middleware (add templates/db-init.yaml) and wire common.db-secret, common.db_setup_job, common.db_setup_sa, push-secret and bootstrap templates to accept a chart override. Update external-secrets templates to include base64Authz and service env secrets and adjust secret naming/resolution to use the new context/override. Switch gearbox and portal images to local test repositories/pullPolicy and expose a global.gearboxMatchingImage used by gearbox and gearbox-middleware (also add an initContainer to run DB migrations). Add postgres configuration to gearbox-middleware values.yaml and enable gearbox/gearbox-middleware by default in the default values. Remove jwt-keys templates and related volume mounts/secret references. Also tidy Chart.yaml dependencies for gearbox-middleware.
grugna
reviewed
May 12, 2026
grugna
reviewed
May 12, 2026
grugna
reviewed
May 12, 2026
|
@paulmurdoch19 after I merged the other PR there is a small conflict, could you resolve it please? |
Switch default image references to quay.io builds and set appropriate tags/pullPolicies in gearbox-default-values.yaml (backend, frontend, middleware). Remove the ENABLE_PHI option from the gearbox chart (values.yaml, templates/deployment.yaml, and README) and simplify the gearboxG3auto/gearboxMiddlewareG3auto default secret maps in the Helm READMEs. Minor cleanup of commented legacy image entries.
Add S3_PROD_BUCKET_NAME environment variable to the gearbox deployment and include PROD_PROMOTION_ROLE_ARN in the gearbox credentials secret. Wire these to the gearboxG3auto Helm values (s3ProdBucketName, prodPromotionRoleArn) and perform a small values.yaml formatting cleanup. This enables configuring the production S3 bucket name and promotion role ARN via Helm values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a context-aware refactor of common Helm templates to support chartNameOverride and use a passed-in root context for lookups. Move DB initialization manifests into gearbox-middleware (add templates/db-init.yaml) and wire common.db-secret, common.db_setup_job, common.db_setup_sa, push-secret and bootstrap templates to accept a chart override. Update external-secrets templates to include base64Authz and service env secrets and adjust secret naming/resolution to use the new context/override. Switch gearbox and portal images to local test repositories/pullPolicy and expose a global.gearboxMatchingImage used by gearbox and gearbox-middleware (also add an initContainer to run DB migrations). Add postgres configuration to gearbox-middleware values.yaml and enable gearbox/gearbox-middleware by default in the default values. Remove jwt-keys templates and related volume mounts/secret references. Also tidy Chart.yaml dependencies for gearbox-middleware.