Skip to content

Update dependencies#149

Merged
chipp merged 1 commit intomainfrom
update-dependencies
Feb 16, 2026
Merged

Update dependencies#149
chipp merged 1 commit intomainfrom
update-dependencies

Conversation

@chipp
Copy link
Owner

@chipp chipp commented Feb 16, 2026

No description provided.

@chipp chipp enabled auto-merge February 16, 2026 12:40
@gemini-code-assist
Copy link

Summary of Changes

Hello @chipp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request comprehensively updates the project's Rust dependencies to their latest stable versions. The primary goal is to ensure the codebase benefits from the most recent features, performance improvements, and security patches provided by the updated crates. This involved significant changes to Cargo.lock and Cargo.toml files, along with minor code modifications to adapt to updated APIs in md5 and rand. Additionally, Docker build commands were simplified by removing outdated caching arguments.

Highlights

  • Core Dependency Upgrades: Major version bumps for key crates including jsonwebtoken, md5, rusqlite, nix, tokio-tungstenite, zip, rand, and socket2.
  • Cargo.lock Synchronization: Extensive updates to transitive dependencies and checksums within Cargo.lock to reflect the new versions, alongside the addition of several new packages and removal of outdated ones.
  • Build Process Streamlining: Removed redundant --cache-from arguments from Docker build commands in the Makefile for various binaries.
  • API Adaptations: Minor code adjustments in lib/inspinia and lib/sonoff to align with updated dependency APIs, specifically changing md5::Context::compute() to md5::Context::finalize() and rand::Rng::fill() to rand::Rng::fill_bytes().

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Cargo.lock
    • Updated numerous package versions and checksums.
    • Added new packages: chacha20, find-msvc-tools, leb128fmt, prettyplease, rsqlite-vfs, semver, signature, sqlite-wasm-rs, typed-path, unicode-xid, wasm-encoder, wasm-metadata, wasmparser, wit-bindgen and related crates, and zmij.
    • Removed packages: addr2line, arbitrary, backtrace, derive_arbitrary, fnv, gimli, libz-rs-sys, object, ring, rustc-demangle, untrusted, and wasi.
  • Makefile
    • Removed '--cache-from' arguments from Docker build commands for 'alisa', 'elisa', 'isabel', and 'elisheba' targets.
  • bin/alisa/Cargo.toml
    • Updated 'jsonwebtoken' from '9.3' to '10.3'.
  • bin/elizabeth/Cargo.toml
    • Updated 'md5' from '0.7.0' to '0.8.0'.
  • bin/isabel/Cargo.toml
    • Updated 'rusqlite' from '0.34' to '0.38'.
  • lib/bluetooth/Cargo.toml
    • Updated 'nix' from '0.29.0' to '0.31.1'.
  • lib/inspinia/Cargo.toml
    • Updated 'tokio-tungstenite' from '0.26.2' to '0.28.0'.
    • Updated 'md5' from '0.7' to '0.8'.
    • Updated 'rusqlite' from '0.34' to '0.38'.
    • Updated 'zip' from '3.0' to '8.0'.
  • lib/inspinia/src/template.rs
    • Changed 'md5::Context::compute()' to 'md5::Context::finalize()'.
  • lib/sonoff/Cargo.toml
    • Updated 'rand' from '0.9' to '0.10'.
    • Updated 'socket2' from '0.5' to '0.6' with the 'all' feature.
  • lib/sonoff/src/client/request.rs
    • Changed 'rand::rng().fill()' to 'rand::rng().fill_bytes()'.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates multiple dependencies across the project. The code has been partially updated to reflect API changes in md5 and rand crates.

My review focuses on the correctness of these migrations and other changes. I've found a critical issue in lib/inspinia/src/template.rs where the migration for the md5 crate is incomplete, which will lead to a compilation failure. I've also pointed out a potential performance degradation in the build process due to the removal of Docker caching in the Makefile.

Please see my detailed comments below.

context.consume(&response[16..]);

let result_hash = context.compute();
let result_hash = context.finalize();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While changing compute() to finalize() is a necessary step for updating the md5 crate to version 0.8, this change is incomplete and the code will not compile. The md5::Context type alias and the consume() method have been removed in this version.

You should use md5::Md5 and the update() method from the digest::Digest trait instead. Here's an example of how to fix this:

use md5::{Digest, Md5};
// ...
pub async fn download_template(target_id: &str) -> Result<PathBuf> {
    // ...
    let mut context = Md5::new();

    let mut expected_hash = [0u8; 16];
    expected_hash.copy_from_slice(&response[..16]);

    context.update(&response[16..]);

    let result_hash = context.finalize();

    if expected_hash[..] != result_hash[..] {
        panic!("invalid hash");
    }
    // ...
}

--build-arg RUST_VERSION="${RUST_VERSION}" \
--load \
--label "org.opencontainers.image.source=https://github.com/chipp/lisa" \
--cache-from=type=registry,ref=${IMAGE_ID}:cache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the --cache-from flag disables Docker's build cache, which can significantly increase build times, especially in CI environments. This change is repeated for all build targets in this file. If this was unintentional, please consider re-adding it to maintain build performance.

@chipp chipp merged commit 48f1bd1 into main Feb 16, 2026
6 checks passed
@chipp chipp deleted the update-dependencies branch February 18, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant