Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Add ability to resolve attr for view styles #187

Open
jlandrum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ability to resolve attr for view styles #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e8185
Add attr resolution for view styles
jlandrum Jul 8, 2015
0d615fa
Remove debug string that breaks attr resolution
jlandrum Jul 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion calligraphy/src/main/java/uk/co/chrisjenx/calligraphy/CalligraphyUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,26 @@ static String pullFontPathFromView(Context context, AttributeSet attrs, int attr
final int stringResourceId = attrs.getAttributeResourceValue(null, attributeName, -1);
return stringResourceId > 0
? context.getString(stringResourceId)
: attrs.getAttributeValue(null, attributeName);
: pullFontPathFromAttribute(context, attrs.getAttributeValue(null, attributeName));
}

/**
* Tries to convert from an attribute to a String
*/
static String pullFontPathFromAttribute(Context context, String attribute) {
String value = null;
if (attribute != null && attribute.startsWith("?")) {
try {
int identifier = context.getResources().getIdentifier(attribute.substring(1),
"attr",
context.getPackageName());
TypedValue attr = new TypedValue();
context.getTheme().resolveAttribute(identifier, attr, true);
value = attr.coerceToString().toString();
} catch (NullPointerException ignore) { /* Handle a missing attr or invalid value */ }
}
if (value == null) value = attribute; // Allow this to work as it always has
return value;
}

/**
Expand Down