Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Support Regular/Bold/Italic based on textStyle attribute#195

Open
netmaxt3r wants to merge 6 commits into
chrisjenx:masterfrom
netmaxt3r:master
Open

Support Regular/Bold/Italic based on textStyle attribute#195
netmaxt3r wants to merge 6 commits into
chrisjenx:masterfrom
netmaxt3r:master

Conversation

@netmaxt3r
Copy link
Copy Markdown

No description provided.

@chrisjenx
Copy link
Copy Markdown
Owner

Thanks for this, this looks interesting. I've been searching for a better way of building the font families, actually creating Typeface families natively that way we would not need to do any logic ourselves.

@technoir42
Copy link
Copy Markdown

I would love to see this feature implemented!

@joaofyz
Copy link
Copy Markdown

joaofyz commented Aug 18, 2015

Very nice feature.

When you plan to release a new version with this?

@mateusgrb
Copy link
Copy Markdown

Very nice and useful feature!

@swellner
Copy link
Copy Markdown

swellner commented Jul 6, 2016

This pull request is still open. When you release this feature? Thank you

@evanverses
Copy link
Copy Markdown

This would be good on future release. Plz merge

@natario1
Copy link
Copy Markdown

Any info about this? It’s more than one year old.

@natario1
Copy link
Copy Markdown

By the way:

  1. The current logic is not 100% compliant with the proposed description in README. For example, if the font is italic, it will look for -RegularItalic, while it should look for -Italic.
  2. As is, it doesn’t work with the default font set in CalligraphyConfig, which is what you would expect. The logic should probably be moved in TypefaceUtils.load(), with some signature changes.

Also if - say - bold is not present we should fallback to regular.

@chrisjenx I have read elsewhere that you were planning to use a different technique. Are you still working on that? Can we help in some way?

@MGaetan89
Copy link
Copy Markdown

Is there any news regarding this PR or support for setting multiple font types?

@chrisjenx
Copy link
Copy Markdown
Owner

I would fork and use this yourself, we are going to do another mechanism to do this.

@MGaetan89
Copy link
Copy Markdown

Thanks for the info.
I can wait for the official solution.
Any (approximate) idea when it will be released?

@MGaetan89
Copy link
Copy Markdown

@chrisjenx Is there any update on the implementation of this feature?

Copy link
Copy Markdown

@Manikkumar1988 Manikkumar1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please approve this PR

@chrisjenx
Copy link
Copy Markdown
Owner

This kind of thing makes more sense to use with either https://github.com/InflationX/ViewPump or the native supported font's built into Google Play Services now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants