Hide PTT detected-device cards when every channel is already configured#382
Closed
chrissnell wants to merge 1 commit into
Closed
Hide PTT detected-device cards when every channel is already configured#382chrissnell wants to merge 1 commit into
chrissnell wants to merge 1 commit into
Conversation
On the PTT page, when every modem-backed channel already has a PttConfig,
the detected-hardware section still rendered a prominent green "Recommended
for PTT" card in a greyed-out, unclickable state. Operators read the
disabled card as a malfunction -- "the Digirig PTT is greyed out" -- even
though their PTT was configured and working; the card was only the
add-hardware shortcut, inert because no channel needed PTT.
Suppress the detected-device cards in the all-configured state and let the
existing inline notice ("Every modem-backed channel already has a PTT
configuration. Edit an existing configuration above to change its device.")
carry the guidance. The no-modem-channel state is unchanged: there the
detected cards stay visible to show what hardware was found and motivate
creating a channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GRA-184. An operator on a Pi reported the "Digirig PTT method is greyed out." The screenshot shows the real situation: their only channel (VHF APRS) already has Digirig Lite Tone PTT configured and working. What's greyed out is the "Recommended for PTT" card (a CM108AH at
/dev/hidraw3, USB0d8c:0012) in the detected-hardware section.That card is disabled because every modem-backed channel already has a PttConfig (
pttDetectionBlockedReason === 'all-configured') — there's nothing to attach a new device to. But a prominent green "RECOMMENDED FOR PTT" header sitting over a greyed, unclickable card reads as a malfunction, even though the operator's PTT is fully set up.Fix
When
all-configured, suppress the detected-device cards entirely and let the existing inline notice carry the guidance:The
no-modem-channelstate is unchanged — there the detected cards stay visible (disabled) so a fresh-install operator can see what hardware was found and is nudged to create a channel first.Template-only change. All 365 web unit tests pass;
Ptt.sveltecompiles clean.Note
This is the desktop/Pi half of GRA-184. A separate PR (#380) fixes a distinct Android-only flow bug where the same tone-PTT method dead-ended on an empty device-picker step.