feat(validator): support VAO affinity overrides#290
Merged
Conversation
5b2f07d to
918f2f9
Compare
918f2f9 to
70d8294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vao.affinitysupport to the validator chart.vao.affinityoverglobal.affinityonly in the VAO deployment, so VAO-specific scheduling rules do not overconstrain ghost pods.0.6.2.testnet-envs-values.yamlextra-volume install test.Why
The stage critical-node fix needs hard cross-namespace anti-affinity for VAO pods only. The chart previously rendered only
global.affinityfor both ghost and VAO, which made a values-only fix too broad.Verification
helm-docs --chart-search-root charts --template-files README.md.gotmpl --template-files _templates.gotmplhelm lint charts/validatorct lint --config ct.yaml --charts charts/validatorgit -C charts diff --checkhelm template test charts/validator -f charts/validator/ci/testnet-envs-values.yaml --show-only templates/extra-manifests.yamlhelm template test charts/validator --show-only templates/deployment-vao.yaml -f /tmp/validator-vao-affinity-test-values.yamlhelm template test charts/validator --show-only templates/deployment.yaml -f /tmp/validator-vao-affinity-test-values.yaml