fix(questhelper): require LoS before direct interaction; default to first available action#1755
Open
runsonmypc wants to merge 1 commit intochsami:developmentfrom
Open
Conversation
…irst available action
Three related improvements to the quest helper auto-runner so it stops
clicking through closed doors, picking the wrong menu option, and
crashing other plugins via null MenuOptionClicked events.
Reachability:
- applyNpcStep direct-click now also requires npc.hasLineOfSight().
Rs2Walker.canReach() pathfinds through closed doors (the walker
opens them en route), so canReach==true alone doesn't guarantee a
direct interaction will succeed.
- applyObjectStep walk gate now also fires when LoS to the target is
blocked, so the walker can route the player past the blocking
geometry instead of us bouncing on "I can't reach that!".
Menu option selection:
- chooseCorrect{Object,NPC,Item}Option fall back to the entity's
first non-empty action when no step-text keyword matches, instead
of returning "" / "use" / "Talk-to" blindly.
Null safety on MenuOptionClicked subscribers:
- Rs2Gembag, PouchScript, QuestBankTabInterface and IncantationStep
now early-return on null event.getMenuOption(); these previously
threw NPEs whenever a programmatic menu invoke fired with a null
option, spamming the chat box with stack traces.
- Removed a stray System.out.println in PouchScript.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis pull request addresses null-safety across multiple microbot plugin files and refines interaction logic in the questhelper module. Changes include defensive null checks for 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyNpcStep/applyObjectSteprequire line-of-sight before direct interaction;Rs2Walker.canReach()alone is insufficient because it pathfinds through closed doors. The walker now handles the door-opening before we click instead of us bouncing on "I can't reach that!".chooseCorrect{Object,NPC,Item}Optionfall back to the entity's first non-empty action when step text doesn't match a known verb, instead of returning empty / "use" / "Talk-to" blindly.event.getMenuOption()in fourMenuOptionClickedsubscribers (Rs2Gembag,PouchScript,QuestBankTabInterface,IncantationStep); they were spamming NPEs whenever a programmatic invoke fired with a null option. Also removed a straySystem.out.printlninPouchScript.Test plan
Cannot invoke "String.equals"/"contains"/"startsWith" because ... getMenuOption() is nullduring quest runs.MenuOptionClickedwith a non-null option still triggers the original code paths (gem bag empty/fill, pouch fill/empty, quest bank tab close, Shadow of the Storm incantation).