fix(walker): convert unbounded recursion to iterative loop

[seppulcro]

Bug: Walking long paths via world map (e.g. to Lighthouse for Horror from the Deep) causes the client to freeze with cascading TimeoutExceptions when the
walker hits a stuck condition near obstacles.

Cause: processWalk() recurses at 3 call sites with no depth limit, flooding the client thread queue.

Fix: Iterative while(true) loop with MAX_RECALC_ATTEMPTS=15. Returns UNREACHABLE cleanly instead of crashing.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b2a0ba03-e140-4c88-a59f-d4374e1d4584

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The processWalk method was refactored from recursive retry calls to an iterative loop with explicit state tracking. A MAX_RECALC_ATTEMPTS constant (15) was introduced to cap recalculation attempts; when exceeded, the walker returns WalkerState.UNREACHABLE and clears the target. Partial-path retries now increment a counter and continue the loop instead of recursing. Exception handling was simplified to directly return WalkerState.EXIT without additional logging paths.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: converting unbounded recursion to an iterative loop in the walker module.
Description check	✅ Passed	The description clearly explains the bug, its root cause, and the implemented fix, all directly related to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java`:
- Around line 615-622: recalcAttempts is being incremented every loop iteration
in Rs2Walker (causing premature UNREACHABLE returns); change logic so
recalcAttempts is only incremented when you actually trigger a path
recalculation (e.g., inside the branch that calls recalculatePath() or in the
stall-detection branch), not on normal progress or "off-path-but-moving" wait
branches, and reset recalcAttempts to 0 whenever the walker makes forward
progress or a new valid path is established; keep the existing behavior that
when recalcAttempts >= MAX_RECALC_ATTEMPTS you log, setTarget(null), and return
WalkerState.UNREACHABLE.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9153c4b8-5e82-4efa-8e85-2ec93b5eda5b

📥 Commits

Reviewing files that changed from the base of the PR and between fe71cce and 0415515.

📒 Files selected for processing (1)

• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java

[seppulcro]

Added an additional with a couple more fixes I noticed while trying to use walker

1. Early-arrive at unwalkable tiles

When the player is adjacent (dist ≤ 1) to a target tile that isn't walkable (e.g. NPC spawn tile, object, wall), return ARRIVED immediately instead of burning all 15 recalc attempts. This was the root cause of the Exceeded max recalc attempts spam during quest helper walks — the pathfinder finds a route but the
exact destination tile has a collision flag, so the walker keeps recalculating despite the player being as close as possible.

2. Preserve minimap zoom on walkMiniMap()

walkMiniMap(WorldPoint) was delegating to walkMiniMap(wp, 5) which force-resets the minimap zoom to 5.0 on every single walk click. This is detectable bot behaviour — real players don't snap their zoom level 50 times a minute. The no-arg overload now reads the current minimap position directly without touching
zoom.