Bugfix: Fix client connection duration display in UI #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate connection start time from last heartbeat tracking - Add client_last_seen dictionary for heartbeat timestamps - Fix register_heartbeat to only update last_seen, preserving connection start time - Update _prune_stale_clients to use last_seen for timeout detection - Fix workflow cache move step to check directory existence - Add workspace cleanup step to fix permission issues
Resolve client connection duration and heartbeat tracking issues
- Add workspace cleanup step to fix permission issues - Add directory existence check in cache move step - Same fixes applied to snd.yml earlier
github-actions
bot
changed the title
chvvkumar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Overview
This pull request addresses a bug in
alpaca/device.pywhere the client connection duration timer was incorrectly resetting every second instead of displaying the connected duration. It improves client management by separating the tracking of initial connection times from last heartbeat timestamps. This ensures accurate monitoring of client activity and proper identification and pruning of stale connections.🔄 Changes by Category
client_last_seendictionary for precise heartbeat timestamp management.register_heartbeatto update only the last seen timestamp, preserving the original connection start time._prune_stale_clientsto utilize thelast_seentimestamp for detecting and removing timed-out clients.📊 Analyzed 8 commit(s) | 🕐 Updated: 2026-01-06T18:44:14.780Z | Generated by GitHub Actions