fix(decorators): wire incident_id in mcp_handler_timeout emit (Wave 0 dedup contract)#463
Merged
cirwel merged 1 commit intoMay 18, 2026
Conversation
… dedup contract)
The @mcp_tool decorator's TimeoutError emit was the one Wave 0 step 2 site missing the incident_id field. The other four wired emitters (asyncpg_connect_error.bootstrap, asyncpg_connect_error.runtime / executor_pool_exhaustion.acquire_timeout, anyio_cancellation.background_task, executor_loop_died.{uncaught,premature_return}) all carry it. Because this site was the only one to fire during the 14-day window, §129's COUNT(DISTINCT payload->>'incident_id') returned 0 vacuously — see docs/proposals/wave-1-window-evaluation-2026-05-18.md Caveat 1.
Single-site fix: add 'incident_id': str(uuid4()) to the emit payload, matching the lazy-import pattern already used in postgres_backend.py and background_tasks.py. Test in test_decorators.py asserts the field is present and parses as a valid UUID.
This restores criterion-evaluability for the next §129 window.
✅ Documentation Validation PassedTool Count: 7 tools tools All documentation is synchronized with the codebase. |
cirwel
deleted the
claude/auto/20260518-160139-fixdecorators-wire-incidentid-in-mcphand
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-shipped by ship.sh — runtime path. Auto-merge is enabled; CI gate applies.