Open
Conversation
mcdonnnj
added
improvement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the llnl-scraper dependency from a direct GitHub tarball to a PyPI release, bumps the project version to 0.3.0-rc.7, and updates all README references accordingly.
- Bump version in
src/version.txtfrom 0.3.0-rc.6 to 0.3.0-rc.7 - Change
llnl-scrapersource insrc/Pipfileto use>=0.15.0from PyPI - Update all occurrences of the old version in
README.mdto 0.3.0-rc.7
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/version.txt | Bumped project version to 0.3.0-rc.7 |
| src/Pipfile | Replaced GitHub tarball pin with PyPI llnl-scraper >=0.15.0 |
| README.md | Updated Docker commands and documentation to use rc.7 tag |
Comments suppressed due to low confidence (1)
src/Pipfile:13
- [nitpick] Rewrite this comment for clarity, for example: "# Minimum version to support newer versions of cloc and avoid GitHub tarball pinning."
# Minimum version with newer versions of cloc compatibility
jsf9k
approved these changes
Jul 13, 2025
dv4harr10
approved these changes
Jul 14, 2025
3 tasks
cisagovbot
pushed a commit
that referenced
this pull request
Jan 1, 2026
Update some label color choices
Member
|
@mcdonnnj - Can we rebase and merge this one? |
mcdonnnj
force-pushed
the
improvement/install_llnl-scraper_from_pypi
branch
from
68fed8d to
a08901c
Compare
github-actions
bot
added
the
documentation
jsf9k
approved these changes
Feb 18, 2026
dav3r
approved these changes
Feb 19, 2026
mcdonnnj
force-pushed
the
improvement/install_llnl-scraper_from_pypi
branch
from
a08901c to
3b1ff4d
Compare
jsf9k
approved these changes
Feb 23, 2026
Member
|
@mcdonnnj - Can we rebase and merge this PR? |
Now that support for newer versions of `cloc` is available from a version installable from PyPI it makes sense to adjust the requirement to reference a version string instead of installing from a commit in a GitHub repository.
Update the dependencies installed in the Python virtual environment by running `pipenv lock` in the `src/` directory.
mcdonnnj
force-pushed
the
improvement/install_llnl-scraper_from_pypi
branch
from
3b1ff4d to
04630b4
Compare
Member
Author
I will test this first thing this week to verify expected functionality and then merge once that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the llnl-scraper dependency to a version constraint so that it is installed from PyPI.
Note
A number of other dependencies were updated when I ran a
pipenv lockto update thellnl-scraperdependency.💭 Motivation and context
Now that a release with support for newer versions of cloc is available on PyPI we should prefer installation of the package from there. This resolves #148.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.✅ Post-merge checklist