Skip to content

Fix/00459 measurements touch bug snapping v2#472

Open
helllth wants to merge 20 commits into
devfrom
fix/00459-measurements-touch-bug-snapping-v2
Open

Fix/00459 measurements touch bug snapping v2#472
helllth wants to merge 20 commits into
devfrom
fix/00459-measurements-touch-bug-snapping-v2

Conversation

@helllth
Copy link
Copy Markdown
Member

@helllth helllth commented Nov 25, 2025 •
edited
Loading

merged pr #468 was reverted

this featurebranch / PR should reproduce the problematic behaviour that was introduced in the dev branch and was reverted
by me with 72fba78

deploy: ["geoportal", "lagis-desktop"]

forced deploy 0

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8ec44ff

Command Status Duration Result
nx run tz-baumbewirtschaftung:build --configura... ✅ Succeeded 58s View ↗
nx run rainhazardmap-haltern:build --configurat... ✅ Succeeded 1m 1s View ↗
nx run baederkarte:build --configuration=produc... ✅ Succeeded 52s View ↗
nx run x-and-ride:build --configuration=product... ✅ Succeeded 54s View ↗
nx run rainhazardmap-euskirchen:build --configu... ✅ Succeeded 59s View ↗
nx run e-bikes:build --configuration=production... ✅ Succeeded 52s View ↗
nx run rainhazardmap-paderborn:build --configur... ✅ Succeeded 57s View ↗
nx run generic-topicmaps-playground:build --con... ✅ Succeeded 47s View ↗
Additional runs (45) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-22 10:29:10 UTC

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 25, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 5599001

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 25, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 5599001

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 25, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 5599001

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 25, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 5599001

@mxfh mxfh force-pushed the fix/00459-measurements-touch-bug-snapping-v2 branch from 0b1370d to 37b6272 Compare December 1, 2025 10:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 8027412

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 8027412

@mxfh mxfh force-pushed the fix/00459-measurements-touch-bug-snapping-v2 branch from 25a8bb3 to 525a830 Compare December 2, 2025 11:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 7cc3c14

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 7cc3c14

@mxfh mxfh requested a review from d4v3000 December 2, 2025 14:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit dc418d0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit dc418d0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit dd25c68

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit dd25c68

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 90e0a95

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 90e0a95

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 2e35762

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 2e35762

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 4680647

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 4680647

@mxfh mxfh force-pushed the fix/00459-measurements-touch-bug-snapping-v2 branch from e209b6c to 259f317 Compare December 3, 2025 13:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 48815f7

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 48815f7

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit adc8a16

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit adc8a16

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 87dea40

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 87dea40

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 029a827

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 769ee95

@mxfh mxfh force-pushed the fix/00459-measurements-touch-bug-snapping-v2 branch 2 times, most recently from e8afe10 to d898393 Compare December 4, 2025 13:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit f8c85cf

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit f8c85cf

mxfh added 20 commits December 22, 2025 11:12
@mxfh
Fix/00459 measurements touch bug snapping (#468)
e08f077 
* typescript build of measure path
* all typescript measurement lib
* new watch build target
* infobox moved out of portals lib
* delete measurement playground
* remove dead code
* wip block leaflet draw touch events
* fix touch issue
* code cleanup
* unified snapping hook
* draw update guide to active snapping point
* remove old InfoBoxMeasurement in commons/cismap lib
* clean up types in measurements
* move per measurement state into the hook
* sync labels with snap
* remove logging in geoportal prod builds
* fix alkis desktop measurement topic map ref handling
* limit snapping by zoom level
* fix typing for snapping and deduplicate extraction
@mxfh
add more logging for clicks
0d8069e
@mxfh
stop circle marker from capturing clicks
c400047
@mxfh
fix build error, fix logged type
b72c1de
@mxfh
fix snapping issue
68d74ec
@mxfh
fix closing issue
3db4606
@mxfh
dedupe distance calculations and use turf
af929bb
@mxfh
refactor and dedupe measurements
85c6b61
@mxfh
fix closing lines with snapping enabled
0709122
@mxfh
wip fix zoom issue
5817fe6
@mxfh
fix vertex ealy close conflict by tracking vertex count
159c83f
@mxfh
collect label strings
f9468b9
@mxfh
collect label strings
e263694
@mxfh
collect more strings, remove external image urls
c868af3
@mxfh
prevent 0 length single point measurements
dc63147
@mxfh
handle geoportal leaflet map modeswitching measure/sachdaten
d3a4efd
@mxfh
consolidate mode switching in geoportal and fix cursor style handling…
04be998 
… conflicts
@mxfh
wipunify snapping unsnaped
d1a0aae
@mxfh
wip unify snapping/unsnapped handling, snap to other measurements
c3018e0
@mxfh
improve close on snap, simplify modifier check
8ec44ff
@mxfh mxfh force-pushed the fix/00459-measurements-touch-bug-snapping-v2 branch from d898393 to 8ec44ff Compare December 22, 2025 10:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 22, 2025

🚀 Deployed geoportal

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/geoportal/

Based on commit 803d468

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 22, 2025

🚀 Deployed lagis-desktop

✅ Preview URL: https://cismet.github.io/carma-pr-deployments/472/lagis-desktop/

Based on commit 803d468

@mxfh
Copy link
Copy Markdown
Contributor

mxfh commented Mar 13, 2026

discussed with @d4v3000 to propose a rebase and short test to see if behavior doesnt regress. then merge. Refactor and typescript gains seem worth it mid to long term as leaflet support is still around.
if no result by end of next week march 20 then close. @helllth
proposed time budget 2h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4v3000 d4v3000 Awaiting requested review from d4v3000

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@helllth @mxfh