Feature/00605 adding compare#622
Open
helllth wants to merge 4 commits into
Open
Conversation
CarmaMapCompare stacks 2+ panels with clip-path in side-by-side (SwipeOverlay) and spyglass modes. Camera sync follows the mapbox-gl-sync-move off/jump/on dance; the `move` listener subscription happens inside handlePanelReady (not a useEffect) to dodge StrictMode's child-before-parent effect ordering, which otherwise let the parent detach the listeners children had just attached.
…maps SpyglassOverlay: the wide hit circle now has pointer-events: all, so both the interior and the edge band are drag handles. Previously only the 16 px edge band caught events; drags inside the ring passed through to the overlay map, which made the Lupe feel awkward. Side effect: click-through onto the overlay map inside the ring is gone; restoring it would need a movement-threshold guard. ComparePlayground: disable the Lupe option in the mode Segmented when numPanels === 3 (it only makes sense with one base + one overlay), and auto-switch an already-active spyglass mode back to sbs-h when the user jumps to 3 Karten (also handles stale localStorage).
LibreMap.buildWMSTileUrl used to hardcode `styles=default` into every WMS request. geoserver-cloud rejects that for cascaded layers with the error "Unknown remote style default", since it forwards the style name to the upstream and there is none called "default". WMS spec: empty STYLES means "use the server's default style". The helper now reads `styles` off the layer config, defaulting to "default" so every existing caller's URL shape is unchanged. The one layer that trips on it (trueOrtho2024Alternative in layerFactory's namedLayers) now sets `styles: ""`. Compare playground: Luftbild preset switched from R102 (maps.wuppertal.de) to GIS-102 (geo.udsp.wuppertal.de) via the alternative key, renamed to "Luftbildkarte 2024" since it's a composite, and a pure "True Ortho 2024" preset added alongside it.
Compare UX batch: - 2x2 grid layout (side-by-side + exactly 4 maps). New gridSplit state holds column (x) and row (y) fractions independently; four inset clip-paths cover the quadrants; two SwipeOverlay instances render the column and row split lines. - SwipeOverlay: dropped the circular grabber entirely; drag handle is now an invisible 16 px wide hit strip centered on the visible 2 px divider line. Cursor flips to col-resize / row-resize on hover to keep the interaction discoverable. - SpyglassOverlay: wheeling over the Lupe resizes the radius. deltaY * 0.3, clamped to [60, 400] to match the slider. New optional onRadiusChange prop on SpyglassOverlay, forwarded from CarmaMapCompare as onSpyglassRadiusChange. - ComparePlayground: 4 Karten option, mode picker replaced by a "Gitter 2x2" static pill when numPanels === 4, sbs-v auto-switches to sbs-h on entering 4-panel mode, Lupe disabled for 3+ panels, True Ortho 2024 preset added, Luftbild renamed to Luftbildkarte 2024, white bezel instead of #111, fourth PANEL_ACCENT color added.
|
View your CI Pipeline Execution ↗ for commit 7f70b51
☁️ Nx Cloud last updated this comment at |
🚀 Deployed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy: ["ng-topicmap-playground"]