Add test suite for Meteor methods and some other server-side code.#338
Open
Torgen wants to merge 4 commits into
Open
Add test suite for Meteor methods and some other server-side code.#338Torgen wants to merge 4 commits into
Torgen wants to merge 4 commits into
Conversation
Contributor
Author
|
I didn't add tests for the bot commands because it turns out Hubot expects bot callbacks to be synchronous, and ours are coroutines, so you can't use the receive callback to detect when they're done like you're supposed to be able to. |
Contributor
Author
|
This also makes some progress on #314 by splitting the server startup and batch code out of lib/model.coffee, though it does still contain both the collections and the methods. |
Contributor
Author
|
If you pull #310 first, wait to pull this until I add back the tests for setStarred. If you pull this first, wait to pull that for the same. |
Rather than by who the message is to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring was necessary because eager loading isn't done in test mode, and some code we didn't want to run during tests was intermingled with code we did. Also, now the client won't download the batch processing code it will never use.
Fixes #161 unless you want some client-side testing, though that can always be added later.
Someone will have to enable Travis for the project for the badge to work, though you will still be able to run tests manually without that.