Check if globals property found by Matcher#53
Open
bobpearson wants to merge 1 commit intocjdev2:masterfrom
Open
Check if globals property found by Matcher#53bobpearson wants to merge 1 commit intocjdev2:masterfrom
bobpearson wants to merge 1 commit intocjdev2:masterfrom
Conversation
A JsHint conf file might not necessarily have a globals property defined. The return of find() should be checked before proceeding to parse the results of matching. The current code generates an IllegalStateException if there is no globals section and group(1) is called. Optimally, a heavy-duty JSON parser lib (Jackson, GSON?) would be ideal, but I realize that is overkill for your project. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JsHint conf file might not necessarily have a globals property defined. The return of find() should be checked before proceeding to parse the results of matching. The current code generates an IllegalStateException if there is no globals section and group(1) is called.
Optimally, a heavy-duty JSON parser lib (Jackson, GSON?) would be ideal, but I realize that is overkill for your project.
Thanks!