added toml_kind_* to inspect item types#92
Draft
jakergrossman wants to merge 4 commits intocktan:masterfrom
Draft
added toml_kind_* to inspect item types#92jakergrossman wants to merge 4 commits intocktan:masterfrom
jakergrossman wants to merge 4 commits intocktan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
While using this for something I wanted to allow multiple types for an item, and more to the point, check that an item was one of a set of types. I found myself using an ugly idiom
where I was blindly trying
toml_*_inand checking the result to know when it was the right type.With access to the innards of the opaque types, this set of fairly straightforward functions allow a more elegant idiom:
The Solution
Adds a new
toml_kind_ttype:Unfortunately
TOML_KIND_TABLEhad to be disambiguated withTOML_KIND_TIME, and now functions that used to return't'for table (liketoml_array_kind()) now return'B'. I am not sure if this is the best solution.