More performance improvements.#166
Merged
clalancette merged 2 commits intomasterfrom Apr 27, 2026
Merged
Conversation
It is always at a fixed position (everywhere but the root directory record), so we can just use that fact rather than iterating. This is admittedly small (we would have hit the dotdot record second), but the code is easier to understand this way too. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Since __lt__ is called for every directory record, we should make it as cheap as possible. We do that by prepending the \x00, \x01, or (artificial) \xff to comparison names at parse/new time, and then just using the string comparison at __lt__ time. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.