Fix UDF large-file support.#167
Merged
clalancette merged 1 commit intomasterfrom Apr 27, 2026
Merged
Conversation
The problem was that UDF file entries for large files specify a single entry with the maximum size, but we were splitting the Inodes up into smaller chunks for ISO9660 support. That means that the UDF File Entry actually only had the size for one of the pieces, not the whole thing. We fix this by having inodes record their extent_offset, which is always 0 for ISO9660 but will be non-zero for very large UDF files. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/fix-udf-large-files
branch
from
d8ed35c to
a1fcd48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that UDF file entries for large files specify a single entry with the maximum size, but
we were splitting the Inodes up into smaller chunks for ISO9660 support. That means that the UDF File Entry actually only had the size for one of the pieces,
not the whole thing.
We fix this by having inodes record their extent_offset, which is always 0 for ISO9660 but will be non-zero for very large UDF files.
Fixes #65