Limit spatial patch filtering to plots with 2d items#322
Open
kbarnhart wants to merge 1 commit intoclawpack:masterfrom
Open
Limit spatial patch filtering to plots with 2d items#322kbarnhart wants to merge 1 commit intoclawpack:masterfrom
kbarnhart wants to merge 1 commit intoclawpack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rjleveque -
I found in my current applications of
1d_from_2d_dataitems that data from some patches are not being plotted when x and y limits are specified because ifskip_patches_outside_xylimitsis not set, it will get set toFalseby this code block.I am sure there is a better way to go about addressing this, but to prompt discussion, I have made a crude attempt.
Specifically, I loop through all
plotitemsand if any of them are of type 1d, thenskip_patches_outside_xylimitsis set toFalse.I'm happy to adjust based on suggestions.