feature/cp-10979-removing-a-subscription-attribute

[unnaticleverpush]

Created removeSubscriptionAttribute(attributeId), removeSubscriptionAttribute(attributeId, CompletionFailureListener) and removeSubscriptionAttributes(attributeIds)

---

Summary by cubic

Adds public APIs and a helper to remove subscription attributes with sequential queues, tracking consent, and SharedPreferences sync. Aligns with Linear CP-10979 to clear single or multiple attributes.

• New Features

  • Added removeSubscriptionAttribute(..) and removeSubscriptionAttributes(..), incl. a CompletionFailureListener overload.
  • Processes removals via a dedicated queue and RemoveSubscriptionAttributes helper; can append IDs while in flight.
  • Updates SharedPreferences after each success via RemoveSubscriptionAttributeResponseHandler.
  • Safely no-ops on null or empty inputs.

• Refactors

  • Split attribute queues into add and remove flows for clearer processing.
  • Added factory methods in SubscriptionAttributeTagRequest and updated tag/attribute paths to use them.

^{Written for commit 3dfb1e3. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cleverpush/src/main/java/com/cleverpush/RemoveSubscriptionAttributes.java">

<violation number="1" location="cleverpush/src/main/java/com/cleverpush/RemoveSubscriptionAttributes.java:75">
P2: `removeSubscriptionAttribute` uses `currentPositionOfAttributeToRemove` without validating it against `attributeIds`, so a caller can trigger an ArrayIndexOutOfBoundsException/NullPointerException. Add a bounds/null guard before using the index.</violation>
</file>

<file name="cleverpush/src/main/java/com/cleverpush/CleverPush.java">

<violation number="1" location="cleverpush/src/main/java/com/cleverpush/CleverPush.java:2659">
P2: Guard against null/empty `attributeId` before enqueueing; otherwise a null input leaves the remove-attribute queue stuck in a processing state and prevents later removals from executing.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}