Drop unused stdio.h include#13
Closed
TravMurav wants to merge 2 commits into
Closed
Conversation
The sha1.c file includes stdio.h without seemingly using it for anyhing. It doesn't make sense for a hash library to use stdio and having that header included makes it harder to use the library in freestanding environment. Drop the include to make it easier to use the library in freestanding projects.
jwerle
approved these changes
Jul 17, 2025
Merged
Member
|
Re-created as #15 to get CI running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've needed a SHA1 implementation in a freestanding project and this library fits nicely. However the implementation includes the
stdio.hheader I don't have. It doesn't seem like the hash library actually needs stdio for anything (and why would it...)For now I had to create an empty header file but I think it makes more sense to drop the include.
This PR just drops the header include from
sha1.c