Optimize block iteration to prevent memory leaks#119
Open
LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
Open
Optimize block iteration to prevent memory leaks#119LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes a crash caused by
block_in_rangeandblock_in_fovdoing way too many block checks.A script was calling
block_in_range~60 times per second, and each call could go through ~32k blocks. After running for a while the client would lag out and eventually crash.boxIterator()now starts at the center and spirals out, stopping early instead of scanning the whole box.block_in_fovnow uses raycasting instead of scanning a volume.This massively reduces the number of block checks per call.
Related issues
Fixes crashes when scripts spam
block_in_rangeorblock_in_fov.Checklist: