cleaning up the vscode questionnaire by pessi-v · Pull Request #138 · climateandtech/carbonara

pessi-v · 2025-11-10T17:40:53Z

Change references to questionnaire to be "Assessment Questionnaire", not "co2 assessment" or anything else
Some changes in how the questionnaire is presented in VSCode
Some changes to the questionnaire answers
Some changes to questions

Pull Request Checklist

Legal Requirements

I have read and agree to the Contributor License Agreement
I understand that by contributing to this project, I grant the Carbonara team a perpetual, irrevocable license to use my contributions under the BSD license, while the public project remains under AGPL-3.0-or-later

Code Quality

My code follows the project's coding style and conventions
I have added appropriate tests for my changes
All new and existing tests pass
I have updated documentation where necessary

Description

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Performance improvement
Test improvements

Testing

Unit tests
Integration tests
Manual testing
E2E tests (if applicable)

Additional Notes

suung · 2025-11-13T15:48:17Z

      Object.entries(data.categoryBreakdown).forEach(([category, score]) => {
-        const scoreColor = (score as number) >= 7 ? 'green' : (score as number) >= 4 ? 'yellow' : 'red';
-        console.log(`      ${category}: ${chalk[scoreColor](score + '/10')}`);
+        const scoreColor =


@grrrau all of these calculations we might want to check

suung · 2025-11-13T15:53:29Z

        // Fallback: wait additional time for CLI process to complete
        await vscode.window.waitForTimeout(3000);
      }



@pessi-v this test should exist, I just made it pass again on #146

suung · 2025-11-13T15:53:48Z

-          }
-        }
-      }
+  //       // Look for the Data & Results section


same, all the test should exist

@pessi-v the tests are still commented out, do you need something?

suung · 2025-11-13T15:54:03Z

-      if (!foundAnalysisTree) {
-        dataTree = allTrees.nth(1);
-      }
+  //       // Click on Data & Results section to ensure it's expanded and active


test should exist

suung · 2025-11-13T15:54:22Z

+  //       // Debug: Let's see what tree sections we have available

-          const errorMessage = `Expected to find test analysis results in Data & Results tab.
+  //       const allTreeSections = vscode.window.locator(".pane-header");


test should exist

suung · 2025-11-13T15:54:34Z

-        } else {
-        }
-      }
+ //         throw new Error(errorMessage);


test should exist

suung · 2025-11-13T15:55:05Z

-    // Create .carbonara directory structure
+    // Note: Don't create .carbonara directory here - let each test create it
+    // This ensures the provider doesn't initialize with an empty database
    const carbonaraDir = path.join(tempDir, ".carbonara");


suung · 2025-11-13T15:55:43Z

    });

-    test("should load and display data when assessment data exists", async function () {
+    test.skip("should load and display data when assessment data exists", async function () {


test should exist, see above and #146

suung · 2025-11-13T15:57:46Z

+import * as fs from "fs";
+import { ToolsTreeProvider, ToolItem } from "../../tools-tree-provider";
+
+suite("ToolsTreeProvider Unit Tests", () => {


this file looks fine, pls double check if all tests are still there

suung

Looks good, but tests have been removed that should be brought back

grrrau

can i get a sshot please, of the state of the changes?

pessi-v · 2025-11-13T19:22:29Z

pessi-v · 2025-11-14T09:49:13Z

Ok, I'm going to hand this over to yous now, because I won't be able to work anymore. There's some tests that need fixing, but otherwise it should be good to go.

I fixed the initialisation to work with the last few merges and this branch
There's a popup after each Questionnaire is completed, and a popup in the end

@grrrau @suung

pessi-v · 2025-11-14T09:52:48Z

suung · 2025-11-14T12:04:46Z

Ok, I'm going to hand this over to yous now, because I won't be able to work anymore. There's some tests that need fixing, but otherwise it should be good to go.

I fixed the initialisation to work with the last few merges and this branch

There's a popup after each Questionnaire is completed, and a popup in the end

@grrrau @suung

@pessi-v well noted, thanks for your efforts so last minute before holiday.

pessi-v · 2025-11-26T22:45:46Z

Dried up, added tests, made sure that the new questions are included in cli and in vscode @suung

pessi-v · 2025-11-27T15:26:54Z

@suung can I merge this?

suung · 2025-11-27T15:34:38Z

@suung can I merge this?
@pessi-v
I didn'f see if all the teste are brought back (see my previous comment). For me it is super important, that the test coverage remains stable from now on. On main there is also quite some updates to the e2e coverage on data loading.

I haven't looked through the code yet.

suung

tests are still commented out

suung · 2025-12-09T01:16:13Z

@grrrau Those changes are now in slightly different form on main, you can check the screenshots above to see if there is something you would want to port, it should be easy, namely

main has a folder icon instead of the arrow in the questionnaire
maybe something about the data & results style (i am not 100% sure whats the difference between the 2 codescan types there)

pessi-v mentioned this pull request Nov 10, 2025

Cleaning up the questionnaire #100

Open

pessi-v force-pushed the cleanup-questionnaire branch from 18b1638 to ec68e1d Compare November 13, 2025 14:28

pessi-v requested review from grrrau and suung November 13, 2025 15:14

suung reviewed Nov 13, 2025

View reviewed changes

Comment thread packages/cli/src/commands/assess.ts Outdated

suung reviewed Nov 13, 2025

View reviewed changes

suung requested changes Nov 13, 2025

View reviewed changes

grrrau reviewed Nov 13, 2025

View reviewed changes

pessi-v force-pushed the cleanup-questionnaire branch from a272d32 to a521977 Compare November 13, 2025 19:21

pessi-v added 9 commits November 26, 2025 18:13

rebasing

ce21123

rebase

b4e57c1

fix tests

b384432

rebasing

7a0e796

rebasing

366f716

rebasing

1197fec

replace co2-assessment and CO2Assessment in a few places

85bd3e7

fix a typescript error in AssessmentTreeProvider

3b15e02

Dry assessment questionnaire code

60d9003

pessi-v force-pushed the cleanup-questionnaire branch from f2de23c to 60d9003 Compare November 26, 2025 19:00

pessi-v added 6 commits November 26, 2025 22:15

add tests

0980ac2

fixing tests

8c6b013

fixing tests

51fa169

fix test

7710b76

fixing tests

cee67b9

fixing tests

b2807cb

pessi-v requested a review from suung November 26, 2025 22:45

suung added this to the November Release milestone Nov 27, 2025

suung requested changes Nov 27, 2025

View reviewed changes

uncomment and fix test

78fc6d0

pessi-v requested a review from suung November 27, 2025 17:13

suung added the is it obsolete? label Dec 9, 2025

Conversation

pessi-v commented Nov 10, 2025

Pull Request Checklist

Legal Requirements

Code Quality

Description

Type of Change

Testing

Additional Notes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suung left a comment

Choose a reason for hiding this comment

Uh oh!

grrrau left a comment

Choose a reason for hiding this comment

Uh oh!

pessi-v commented Nov 13, 2025

Uh oh!

pessi-v commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pessi-v commented Nov 14, 2025

Uh oh!

suung commented Nov 14, 2025

Uh oh!

pessi-v commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pessi-v commented Nov 27, 2025

Uh oh!

suung commented Nov 27, 2025

Uh oh!

suung left a comment

Choose a reason for hiding this comment

Uh oh!

suung commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pessi-v commented Nov 14, 2025 •

edited

Loading

pessi-v commented Nov 26, 2025 •

edited

Loading