Refactor cli calling to be the same way everywhere#74
Open
suung wants to merge 6 commits into
Open
Conversation
- Fix bug in json mode - Add better seperation of workspace fixtures with and without data and use them across all tests - Remove test that tests arbitrary performance - Add build scripts for package management
suung
commented
Oct 10, 2025
| @@ -278,6 +278,114 @@ test.describe('Carbonara VSCode Extension E2E Tests', () => { | |||
| } | |||
| }); | |||
|
|
|||
| test('Scenario 1: Load workspace with existing data - data should appear', async () => { | |||
Collaborator
Author
There was a problem hiding this comment.
I separated the test scenarios for existing data to be shown, no data and, no data but after tool calling there should be data
suung
commented
Oct 10, 2025
| #!/usr/bin/env node | ||
|
|
||
| // Script to add test-analyzer data to the with-carbonara-project fixture | ||
| const sqlite3 = require('sqlite3').verbose(); |
Collaborator
Author
There was a problem hiding this comment.
Would need to change to sql.js
Collaborator
There was a problem hiding this comment.
// Check that project was created in database
const initSqlJs = require('sql.js');
const SQL = await initSqlJs();
const dbData = fs.readFileSync(dbPath);
const db = new SQL.Database(dbData);
suung
changed the title
pessi-v
reviewed
Oct 13, 2025
|
|
||
| # Build artifacts | ||
| out/ | ||
| # out/ - commented out because this contains the compiled extension |
Collaborator
There was a problem hiding this comment.
The build folder is now dist/ and as such unified with the rest of the carbonara project
Collaborator
Author
There was a problem hiding this comment.
@pessi-v thanks, so how should (or does) this file look like?
- Keep CLI integration as active implementation - Preserve core integration code as comments for future use - Update test structure to match main branch organization - Fix CI test skipping to run unit/integration tests - Add packaging scripts for versioned builds - Update fixture paths to new test structure
- Add headless mode arguments for CI environments - Prevents X server errors in Linux CI environments - Tests now run successfully in CI without display server
- Add comprehensive headless arguments for CI environments - Include --headless, --disable-web-security, and other display-related flags - Should resolve Missing X server or DISPLAY errors in CI
Merged
- Remove --disable-dev-shm-usage which may cause issues - Keep only --no-sandbox and --disable-gpu for CI - These are the most reliable arguments for VSCode extension testing in CI
- Revert runTest.ts to original state without headless arguments - Update test:ci-check to skip VSCode extension tests entirely in CI - VSCode extension tests require a display server which is not available in CI - This allows CI to pass while keeping local testing functional
pessi-v
approved these changes
Oct 20, 2025
Collaborator
pessi-v
left a comment
pessi-v
left a comment
There was a problem hiding this comment.
The tests should be using sql.js, but otherwise fine
Collaborator
Author
can you point me to that @pessi-v how it should be? |
Collaborator
|
Collaborator
Collaborator
Author
|
@grrrau I am not sure anymore about this one, It's in december release which seems fine, I would suggest we discuss it after a round of testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.