Skip to content

Remove Promise.withResolvers; unsupported in Node 20.x #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshua-spacetime wants to merge 2 commits into from
+18 −2
Closed

Remove Promise.withResolvers; unsupported in Node 20.x #4353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23922cf
Remove Promise.withResolvers; unsupported in Node 20.x
joshua-spacetime Feb 19, 2026
d267d6b
Merge branch 'master' into joshua/remove-with-resolvers
joshua-spacetime Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions crates/bindings-typescript/src/sdk/db_connection_impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,22 @@ export type DbConnectionConfig<RemoteModule extends UntypedRemoteModule> = {

type ProcedureCallback = (result: ProcedureResultMessage['result']) => void;

type Deferred<T> = {
promise: Promise<T>;
resolve: (value: T | PromiseLike<T>) => void;
reject: (reason?: unknown) => void;
};

function createDeferred<T>(): Deferred<T> {
let resolve!: (value: T | PromiseLike<T>) => void;
let reject!: (reason?: unknown) => void;
const promise = new Promise<T>((res, rej) => {
resolve = res;
reject = rej;
});
return { promise, resolve, reject };
}

export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
implements DbContext<RemoteModule>
{
Expand Down Expand Up @@ -820,7 +836,7 @@ export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
argsBuffer: Uint8Array,
reducerArgs?: object
): Promise<void> {
const { promise, resolve, reject } = Promise.withResolvers<void>();
const { promise, resolve, reject } = createDeferred<void>();
const requestId = this.#getNextRequestId();
const message = ClientMessage.CallReducer({
reducer: reducerName,
Expand Down Expand Up @@ -884,7 +900,7 @@ export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
procedureName: string,
argsBuffer: Uint8Array
): Promise<Uint8Array> {
const { promise, resolve, reject } = Promise.withResolvers<Uint8Array>();
const { promise, resolve, reject } = createDeferred<Uint8Array>();
const requestId = this.#getNextRequestId();
const message = ClientMessage.CallProcedure({
procedure: procedureName,
Expand Down
Loading