Closed
Conversation
Co-authored-by: David Perez <davidperezgar@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: David Perez <davidperezgar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the non-functional connection tab select in WPForms by normalizing CRM options and moving dependency logic to a dedicated JavaScript file.
The previous implementation of the select in the WPForms connection tab was not capturing values correctly, often appearing empty, because
formscrm_get_choices()returned an empty set if no filters were active. Additionally, the show/hide field logic relied on fragile inline scripts. This PR addresses these issues by ensuring CRM options are properly rendered and by implementing a more robust, dedicated JavaScript solution for field dependencies.