Fix WPForms CRM select output escaping#169
Merged
davidperezgar merged 2 commits intotrunkfrom Mar 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes improper HTML escaping in the WPForms CRM selector dropdown. The
wp_kses_post()function was being used to escape already-escaped<option>HTML, which was stripping validvalueattributes and causing the select to render incorrectly.Changes
<option>valueattribute withesc_attr()instead of leaving it unescaped<option>label text withesc_html()instead of leaving it unescapedwp_kses_post()on the finalprintf()output (which was incorrectly stripping properly-built HTML) with a direct output +phpcs:ignorecomment, since individual values are already escaped at construction timeBenefits
wp_kses_post()stripping valid attribute contentTesting Instructions
Checklist
phpcs:ignorewith justification)