Fix DurationType regex vulnerability and add tests#160
Open
outlookenjoyer wants to merge 1 commit intocloud-custodian:mainfrom
Open
Fix DurationType regex vulnerability and add tests#160outlookenjoyer wants to merge 1 commit intocloud-custodian:mainfrom
outlookenjoyer wants to merge 1 commit intocloud-custodian:mainfrom
Conversation
|
|
outlookenjoyer
force-pushed
the
fix-duration-regex
branch
from
152527c to
2a663e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147 #155
Description
The old regex used
[a-z]+to parse time units, which caused the regex engine to hang on bad inputs likemmmmmmmmmm!Changes
[a-z]+with a hardcoded list of valid units (ms,s,h, etc.)msmatches safely beforemVerification
pytest tests/test_celtypes.py)cc @slott56