feat: migrate to tsdown with flat dist structure#103
Open
dmmulroy wants to merge 1 commit intocloudflare:mainfrom
Open
feat: migrate to tsdown with flat dist structure#103dmmulroy wants to merge 1 commit intocloudflare:mainfrom
dmmulroy wants to merge 1 commit intocloudflare:mainfrom
Conversation
46d6bc2 to
5af6223
Compare
- add tsdown.config.ts with multi-entry points - update package.json exports with types/workerd/import/default conditions - add ./sockets export, remove typesVersions - flatten dist: dist/core/index.js (not dist/core/src/index.js) - fix Entrypoint class type issues with WorkerEntrypoint
5af6223 to
7834fc8
Compare
| "description": "An easier way to build with Cloudflare Durable Objects", | ||
| "type": "module", | ||
| "main": "./dist/index.js", | ||
| "main": "./dist/core/index.js", |
Collaborator
There was a problem hiding this comment.
This would break existing users importing the entire package index, which was the intention I believe here?
lambrospetrou
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@cloudflare/actors/socketsnot exposedtypesfield, TS resolution unreliabledist/core/src/index.jsleaks internal structureworkerd+defaultconditions breaks vitest-pool-workers import resolutionSolution
tsdown bundles each entry point into flat output. conditional exports with
types/workerd/import/defaultconditions ensure resolution works in all contexts (TS, workerd, Node, bundlers).Changes
dist/core/index.jsnotdist/core/src/index.jsVerification
pnpm buildproduces flat dist@cloudflare/actors/storage→ 6.5KB (no Alarms/Sockets code)@cloudflare/actors(full Actor) → 52.5KB@cloudflare/actors@cloudflare/actors/storage@cloudflare/actors/alarms