Proposal for improving types in query method#84
Open
jmorrell wants to merge 1 commit intocloudflare:mainfrom
Open
Proposal for improving types in query method#84jmorrell wants to merge 1 commit intocloudflare:mainfrom
jmorrell wants to merge 1 commit intocloudflare:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is a little odd in that a boolean input changes the expected output type. Given that we also have
executeRawQueryit seems like this might be a leftover from a previous version? I'm not sure it's needed, but let me know if I'm missing something.Removing
isRawallows us to give a template output type similar to thesqlmethod, making this an equivalent function with slightly less template magic.