fix(types): filter symbol keys in RpcCompatible mapped type #129
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bb2fb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
commit: |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Use key remapping to filter out symbol keys instead of mapping to never. Fixes Disposable compatibility issue with RPC types. Ref: cloudflare/workerd#5804
dmmulroy
force-pushed
the
fix-rpccompatible-symbol-keys
branch
from
b6b49b3 to
8bb2fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use key remapping (
asclause) to filter out symbol keys instead of mapping them tonever. FixesDisposablecompatibility issue with RPC types.Context
Per @kentonv's review comment on cloudflare/workerd#5804 - applying the same fix here.
Change
Note
This PR was written with AI assistance.
AI Session Export
{ "info": { "title": "capnweb rpccompatible symbol fix", "agent": "opencode", "models": ["claude opus 4.5"] }, "summary": [ "user requested review of workerd PR #5804", "agent fetched PR details and Kenton's comment about updating capnweb", "agent cloned capnweb to ~/Code/work/ using jj", "agent applied same RpcCompatible fix to src/types.d.ts", "agent created PR referencing workerd#5804" ] }