feat: lightweight worker for static exports by raed04 · Pull Request #733 · cloudflare/vinext

raed04 · 2026-04-01T03:20:53Z

Summary

Closes #566 — strips the full worker from static export builds.

When next.config sets output: "export", vinext deploy now generates a wrangler config that serves pre-rendered files directly via Cloudflare's built-in asset serving — no worker entry, no ASSETS/IMAGES bindings, no KV namespace
Adds isStaticExport detection to ProjectInfo (heuristic: reads next.config, strips // and /* */ comments, matches output: "export")
Relaxes the Cloudflare plugin guard so static export projects don't need @cloudflare/vite-plugin
24 new tests covering detection edge cases, config generation, and file generation

Changes

File	What
`packages/vinext/src/deploy.ts`	`detectStaticExport()`, `isStaticExport` on `ProjectInfo`, static branch in `generateWranglerConfig`, skip worker in `getFilesToGenerate`
`packages/vinext/src/index.ts`	Guard uses `nextConfig.output !== "export"` (already-loaded config)
`tests/deploy.test.ts`	24 new tests: comment stripping, `.cjs`/`.ts`/`.mjs` detection, block comments, standalone negative, empty/missing config, config priority, direct `detectStaticExport`, static/non-static wrangler schema, regression guards

Test plan

240/240 deploy tests pass
TypeScript type check passes (no errors)
Related suites pass: build-report (76), init (59), static-export, prerender
Security: block comment false positive eliminated
Backward compat: non-static output byte-identical to original

pkg-pr-new · 2026-04-01T03:21:34Z

Open in StackBlitz

npm i https://pkg.pr.new/vinext@733

commit: 00a2724

Strip the full worker from static export builds. When next.config sets output: "export", vinext deploy now generates a wrangler config that serves pre-rendered files directly via Cloudflare's built-in asset serving — no worker entry, no ASSETS/IMAGES bindings, no KV namespace. - Add `isStaticExport` to ProjectInfo with heuristic detection (reads next.config, strips single-line and block comments, matches output: "export" / 'export') - generateWranglerConfig: static branch uses not_found_handling: "404-page" - getFilesToGenerate: skip worker/index.ts for static exports - Relax Cloudflare plugin guard: use already-loaded nextConfig.output instead of re-reading disk, so inline config overrides also work - 24 new tests covering detection, config generation, and file generation Closes cloudflare#566

james-elicx · 2026-04-01T12:32:46Z

/bigbonk review

ask-bonk

Review: feat: lightweight worker for static exports

Solid feature addition. The detection heuristic, wrangler config branching, and worker skip logic are well-structured and consistent with the existing detectISR pattern. Tests are thorough. A few issues to address:

Issues

Deploy-time Cloudflare plugin guard not skipped for static exports — deploy() at line 1358 throws if an existing vite.config lacks @cloudflare/vite-plugin, but static export builds don't need it (and this PR already relaxes that guard in index.ts). A user with output: "export" and a vite config from vinext init (which omits cloudflare) will hit this error during deploy.
getMissingDeps still requires @cloudflare/vite-plugin for static exports — The generated wrangler config has no main and no worker, but getMissingDeps() will still install @cloudflare/vite-plugin, @vitejs/plugin-rsc, and react-server-dom-webpack for static export projects. These are unnecessary for pure static builds.
Comment stripping has a known class of false positives — The // regex will strip content inside string literals containing // (e.g., const url = "https://example.com"; output: "export"). This is a pre-existing limitation shared with the block comment regex pattern and is documented as a heuristic, so it's acceptable — just noting it for awareness.
nodejs_compat flag in static-only wrangler config — When isStaticExport is true and there's no worker, the nodejs_compat compatibility flag has no effect (there's no JS execution). It's harmless but misleading. Minor nit.

Positive notes

Good test coverage (24 tests covering all the edge cases)
Consistent with existing detection patterns (detectISR, detectMDX)
Config priority order matches CONFIG_FILES in next-config.ts
The index.ts guard change correctly uses the already-loaded nextConfig instead of re-detecting

ask-bonk · 2026-04-01T12:35:00Z

packages/vinext/src/deploy.ts

+          .replace(/\/\/.*$/gm, "") // single-line comments
+          .replace(/\/\*[\s\S]*?\*\//g, ""); // block comments
+        // Match output: "export" or output: 'export' (enforcing matching quotes).
+        return /output\s*:\s*(?:"export"|'export')/.test(stripped);


Nit: the comment says "enforcing matching quotes" but the regex uses two separate alternations ("export" and 'export'), each with their own matched delimiters. The phrasing is slightly misleading — it implies there's a backreference enforcing that the opening and closing quotes match, but in practice both alternatives are self-consistent so it works correctly. Consider:

Suggested change

return /output\s*:\s*(?:"export"|'export')/.test(stripped);

// Match output: "export" or output: 'export' (double or single quotes).

ask-bonk · 2026-04-01T12:35:00Z

packages/vinext/src/deploy.ts

+    config.assets = {
+      directory: "dist/client",
+      not_found_handling: "404-page",
+    };


When isStaticExport is true and there's no worker entry, nodejs_compat has no effect since there's no JavaScript execution at all — Cloudflare just serves static files. Consider omitting it for static exports to keep the generated config minimal and avoid confusing users who read it:

Suggested change

};

config.assets = {

directory: "dist/client",

not_found_handling: "404-page",

};

} else {

You could conditionally set compatibility_flags only in the non-static branch. Low priority — it's functionally harmless.

ask-bonk · 2026-04-01T12:35:00Z

packages/vinext/src/deploy.ts

+        const content = fs.readFileSync(configPath, "utf-8");
+        // Strip comments to avoid matching commented-out config.
+        const stripped = content
+          .replace(/\/\/.*$/gm, "") // single-line comments


The // comment stripping regex will also match // inside string literals, e.g.:

const baseUrl = "https://example.com"; // this gets partially eaten

becomes const baseUrl = "https: after stripping. If the remaining content accidentally matches the output pattern, you'd get a false positive.

This is a pre-existing limitation (same class of issue as detectISR), and for next.config files it's extremely unlikely to matter in practice. Just documenting for awareness — no action needed unless you want to add a string-preserving pass.

ask-bonk · 2026-04-01T12:35:00Z

packages/vinext/src/deploy.ts

  }

-  if (!info.hasWorkerEntry) {
+  if (!info.hasWorkerEntry && !info.isStaticExport) {


Good — correctly skips worker generation for static exports. But two related guards in the deploy() function are not gated on isStaticExport:

Line 1358: viteConfigHasCloudflarePlugin(root) check will throw for static export projects that have a vite config without @cloudflare/vite-plugin. Should be:

if (info.hasViteConfig && !info.isStaticExport && !viteConfigHasCloudflarePlugin(root)) {

getMissingDeps(): Still installs @cloudflare/vite-plugin, wrangler, @vitejs/plugin-rsc, react-server-dom-webpack even for static exports where no worker runs. Consider gating the cloudflare/rsc deps behind !info.isStaticExport. (wrangler is still needed for wrangler deploy.)

ask-bonk · 2026-04-01T12:35:00Z

packages/vinext/src/index.ts

          hasWranglerConfig(root) &&
-          !options.disableAppRouter
+          !options.disableAppRouter &&
+          nextConfig.output !== "export"


This correctly uses the already-loaded nextConfig from the Vite plugin's config phase rather than re-detecting via file heuristic. Clean approach.

ask-bonk · 2026-04-01T12:35:01Z

tests/deploy.test.ts

+    writeFile(tmpDir, "next.config.mjs", `export default {};`);
+    const info = detectProject(tmpDir);
+    expect(info.isStaticExport).toBe(false);
+  });


Nice edge case — testing the output:"export" form without spaces ensures the \s* in the regex is doing its job.

ask-bonk · 2026-04-01T12:35:01Z

tests/deploy.test.ts

+
+  it("does not detect output: 'export' inside multiline block comments", () => {
+    mkdir(tmpDir, "app");
+    writeFile(


Good: this test verifies the config priority order (.ts > .mjs), which matches CONFIG_FILES in next-config.ts. Worth noting in the test name or comment that this is testing first-match-wins semantics, not alphabetical priority.

ask-bonk · 2026-04-01T12:35:10Z

Review posted successfully. Here's a summary of the feedback:

Key issues found:

Deploy-time Cloudflare plugin guard not skipped for static exports (deploy.ts:1358) — The viteConfigHasCloudflarePlugin() check will throw for static export projects with a vite config that doesn't have @cloudflare/vite-plugin. The index.ts guard was updated but the parallel guard in deploy() was not.
getMissingDeps still installs unnecessary dependencies — @cloudflare/vite-plugin, @vitejs/plugin-rsc, and react-server-dom-webpack will still be installed for static exports where no worker runs. These should be gated behind !info.isStaticExport.
Minor: nodejs_compat flag in the static-only wrangler config is harmless but misleading since there's no JS execution.
Minor: comment stripping regex has a known limitation with // inside string literals (pre-existing pattern, acceptable for config files).

The review also highlighted positive aspects: good test coverage, consistency with existing detection patterns, and the clean approach of using the already-loaded nextConfig in index.ts.

github run

raed04 force-pushed the claude/objective-torvalds branch from bcff738 to 00a2724 Compare April 1, 2026 03:25

ask-bonk bot reviewed Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lightweight worker for static exports#733

feat: lightweight worker for static exports#733
raed04 wants to merge 1 commit intocloudflare:mainfrom
raed04:claude/objective-torvalds

raed04 commented Apr 1, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

james-elicx commented Apr 1, 2026

Uh oh!

ask-bonk bot left a comment

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot Apr 1, 2026

Uh oh!

ask-bonk bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return /output\s:\s(?:"export"\|'export')/.test(stripped);
	// Match output: "export" or output: 'export' (double or single quotes).

Conversation

raed04 commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

pkg-pr-new bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Apr 1, 2026

Uh oh!

ask-bonk bot left a comment

Choose a reason for hiding this comment

Review: feat: lightweight worker for static exports

Issues

Positive notes

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

raed04 commented Apr 1, 2026 •

edited

Loading

pkg-pr-new bot commented Apr 1, 2026 •

edited

Loading