fix: pass thenable params and searchParams to probePage()#763
Open
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Open
fix: pass thenable params and searchParams to probePage()#763NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Conversation
probePage() passed raw null-prototype params instead of thenable params, causing TypeError for any page using the Next.js 15+ async params pattern (await params). The probe also omitted searchParams entirely. Both issues caused the probe to silently fail, defeating its purpose of early notFound() and redirect() detection. The layout probe already used the correct thenable params — the page probe was the only inconsistent path.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
probePage()passed raw null-prototype params instead of thenable params, causing TypeError for pages usingawait params(Next.js 15+ pattern)searchParams, causing pages usingawait searchParamsto failnotFound()/redirect()detection)The fix computes
_asyncSearchParams(URLSearchParams converted to a plain object then wrapped inmakeThenableParams()) alongside_asyncLayoutParams, and passes both to theprobePage()callback — matching the same prop shape thatbuildPageElement()gives to the real render.Test plan
notFound()from an async-params page when params are thenableredirect()from an async-searchParams page when searchParams are thenableawait paramsthennotFound()returns 404await searchParamsthenredirect()returns 307tests/features.test.ts— all 264 tests pass