-
Notifications
You must be signed in to change notification settings - Fork 511
update-deps.py: Allow bazel_dep + archive/git_override #5876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging this PR will degrade performance by 84.24%Comparing Summary
Performance Changes
Footnotes
|
453cee3 to
59df4a3
Compare
59df4a3 to
a8a1239
Compare
fhanau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
| "use_bazel_dep": true, | ||
| "owner": "google", | ||
| "repo": "perfetto", | ||
| "freeze_version": "v53.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: No need to freeze the version per se, it's just that patches might break. Let's add a comment or unfreeze
| "name": "ada-url", | ||
| "type": "bazel_dep" | ||
| }, | ||
| // BoringSSL may subtly break backwards compatibility and behave differently than the latest FIPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this comment, but it seems too pedantic in retrospect: If there are breaking changes, we will likely notice through our tests failing, and the downstream build will not be directly affected. We'll be able to clean up breaking tests as they happen, as with other dependencies. I guess we can reduce the comment to just say that this is expected to break tests more often than other dependencies?
This PR adds a new flag to our existing dependency types for downloading packages:
github_releasegithub_tarballgit_cloneIf
use_bazel_dep: trueis set, we generate abazel_dep()+ an override directive (e.g.archive_override()orgit_override(). Otherwise, we use the existing templates for aWORKSPACEbased repo.Additionally
use_module_bazel_from_bcr: some.version.herecan be used to automatically download an inject aMODULE.bazelfile from BCR if one is available from there, but not in the project itself.This is basically the last PR in my project of upgrading
update-deps.py. There's probably still room for small simplifications / cleanups down the road, but the vast majority of our dependencies are now automated again.