Skip to content

Un-skip hono pages C3 e2e tests#13616

Merged
emily-shen merged 1 commit intomainfrom
dario/un-quarantine-hono-pages-c3
Apr 21, 2026
Merged

Un-skip hono pages C3 e2e tests#13616
emily-shen merged 1 commit intomainfrom
dario/un-quarantine-hono-pages-c3

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 21, 2026

The upstream issue that required us to skip the hono pages C3 e2e tests has been fixed in honojs/vite-plugins#355 so we can re-enable the tests now


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: un-skipping C3 e2e tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: un-skipping C3 e2e tests

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@dario-piotrowicz dario-piotrowicz added the no-changeset-required Skip PR check for valid changeset label Apr 21, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 21, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: d5b6926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod requested review from a team and ascorbic and removed request for a team April 21, 2026 08:59
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 21, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 21, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13616

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13616

miniflare

npm i https://pkg.pr.new/miniflare@13616

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13616

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13616

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13616

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13616

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13616

wrangler

npm i https://pkg.pr.new/wrangler@13616

commit: d5b6926

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 21, 2026
@emily-shen emily-shen merged commit f85f7ef into main Apr 21, 2026
63 of 70 checks passed
@emily-shen emily-shen deleted the dario/un-quarantine-hono-pages-c3 branch April 21, 2026 09:32
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset-required Skip PR check for valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants