MSA-15249: review packaging#1
Merged
abr-ubiqube merged 5 commits intomasterfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container packaging/layout for the cloudflare-ms CommandDefinition repository under /opt/fmc_repository/CommandDefinition, with backward-compatibility handling in the entrypoint.
Changes:
- Install/build paths updated to place
cloudflare-msunder/opt/fmc_repository/CommandDefinition/. - Entrypoint migration logic added to move an existing repo from the legacy
/opt/fmc_repository/cloudflare-mslocation. - Base runtime image updated to
docker.io/ubiqube/ubi-almalinux10:latestand minor message typo fixed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| install.sh | Ensures /opt/fmc_repository/CommandDefinition/ exists and switches working directory there. |
| docker-entrypoint.sh | Adds migration logic (remove symlink, move legacy repo) and fixes “Sucess” typo. |
| Dockerfile | Builds/cleans cloudflare-ms under CommandDefinition, tars only that subtree, updates runtime base image, and ensures directory exists in final image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.