Skip to content

Conversation

@acolum
Copy link
Member

@acolum acolum commented Mar 10, 2020

I've removed the maintainer name so that the package can be successfully downloaded.

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

acolum added 3 commits March 10, 2020 13:28
I've filled in the maintainer name so that the package can be successfully downloaded.
@jonthegeek
Copy link

aws.iam is back alive, so this should pass now, at least on linux. We've removed the mac checks in the other aws.* packages for the moment, you'll also need to do that to get tests to pass.

We're using the cloudyr slack to coordinate discussions of these packages, we'd love to have you there @acolum! Sign up here: https://forms.gle/GhZoRqLQLcSjcmYh9

@acolum
Copy link
Member Author

acolum commented Apr 15, 2020

Thank you, @jonthegeek!

@jonthegeek
Copy link

I'm doing this and more in #48, so I'm closing this PR.

@jonthegeek jonthegeek closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants