Skip to content

Increase throughput of power-of-two formatting by 50% #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lemmih wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Increase throughput of power-of-two formatting by 50% #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3624c
Improve performance when writing a single digit.
lemmih Sep 14, 2022
950ebe1
Merge branch 'cmpute:master' into fix-to-hex
lemmih Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions integer/src/fmt/digit_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ impl<'a> DigitWriter<'a> {
Ok(())
}

pub fn write_digit(&mut self, digit: u8) -> fmt::Result {
self.buffer[self.buffer_len] = digit;
self.buffer_len += 1;
if self.buffer_len == BUFFER_LEN {
self.flush()?;
}
Ok(())
}

/// Must call flush to make sure all the data is written.
pub fn flush(&mut self) -> fmt::Result {
let buffer_len_rounded = math::round_up(self.buffer_len, arch::digits::DIGIT_CHUNK_LEN);
Expand Down
3 changes: 2 additions & 1 deletion integer/src/fmt/power_two.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ impl PreparedForFormatting for PreparedLarge<'_> {
bits -= self.log_radix;
digit = ((word >> bits) & mask) as u8;
}
digit_writer.write(&[digit])?;
// digit_writer.write(&[digit])?;
digit_writer.write_digit(digit)?;
}
debug_assert_eq!(bits, 0);
Ok(())
Expand Down