Increase throughput of power-of-two formatting by 50%#3
Draft
lemmih wants to merge 2 commits intocmpute:masterfrom
Draft
Increase throughput of power-of-two formatting by 50%#3lemmih wants to merge 2 commits intocmpute:masterfrom
lemmih wants to merge 2 commits intocmpute:masterfrom
Conversation
Owner
|
wow, thanks for putting effort into this so quickly! Glad to see this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
大数你好,
This change cuts the formatting time by a lot for large numbers when using a power-of-two radix. It's kinda ugly, though, so I'll try to find a better solution (hence the draft PR).
Before changes (M1 laptop):
After changes (M1 laptop):
Before changes (AMD desktop):
After changes (AMD desktop):