Skip to content

reimplement lowest_dword and highest_dword without unsafe blocks #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardosm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reimplement lowest_dword and highest_dword without unsafe blocks #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions integer/src/primitive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,10 @@ pub const fn shrink_dword(dw: DoubleWord) -> Option<Word> {
/// Note that then length is only checked in the debug mode.
#[inline(always)]
pub fn lowest_dword(words: &[Word]) -> DoubleWord {
debug_assert!(words.len() >= 2);

// SAFETY: length checked by the assertion above
unsafe {
let lo = *words.get_unchecked(0);
let hi = *words.get_unchecked(1);
if let [lo, hi, ..] = *words {
double_word(lo, hi)
} else {
panic!("expected at least two words");
}
}

Expand All @@ -75,14 +72,10 @@ pub fn lowest_dword(words: &[Word]) -> DoubleWord {
/// Note that then length is only checked in the debug mode.
#[inline(always)]
pub fn highest_dword(words: &[Word]) -> DoubleWord {
let len = words.len();
debug_assert!(len >= 2);

// SAFETY: length checked by the assertion above
unsafe {
let lo = *words.get_unchecked(len - 2);
let hi = *words.get_unchecked(len - 1);
if let [.., lo, hi] = *words {
double_word(lo, hi)
} else {
panic!("expected at least two words");
}
}

Expand Down