replace netifaces with pyroute2#150
Open
eshattow wants to merge 1 commit into
Open
Conversation
Author
|
I've gutted the testing coverage because I'm not a python programmer and have no idea how to write the tests. That's the best I know how to do. Let me know what the tests should be and I'll add them w/ co-authored tag and all that, I just have this as a blocker for some other project which uses greeclimate but netifaces is unfixable and unmaintained. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 95.65% 92.72% -2.94%
==========================================
Files 8 8
Lines 760 756 -4
==========================================
- Hits 727 701 -26
- Misses 33 55 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace netifaces with pyroute2