Skip to content

replace netifaces with pyroute2#150

Open
eshattow wants to merge 1 commit into
cmroche:masterfrom
eshattow:drop-netifaces
Open

replace netifaces with pyroute2#150
eshattow wants to merge 1 commit into
cmroche:masterfrom
eshattow:drop-netifaces

Conversation

@eshattow
Copy link
Copy Markdown

replace netifaces with pyroute2

@eshattow
Copy link
Copy Markdown
Author

I've gutted the testing coverage because I'm not a python programmer and have no idea how to write the tests. That's the best I know how to do. Let me know what the tests should be and I'll add them w/ co-authored tag and all that, I just have this as a blocker for some other project which uses greeclimate but netifaces is unfixable and unmaintained.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.72%. Comparing base (cff93f8) to head (d43314c).

Files with missing lines Patch % Lines
greeclimate/discovery.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   95.65%   92.72%   -2.94%     
==========================================
  Files           8        8              
  Lines         760      756       -4     
==========================================
- Hits          727      701      -26     
- Misses         33       55      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant